Fix optoe's write_max when using native i2c driver #407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Prince George <[email protected]>
|
@bingwang-ms please include this fix in 202405 |
|
@StormLiangMS please include this fix in 202311 |
|
@lguohan please review/merge. thanks. |
This was referenced Jun 19, 2024
saiarcot895
reviewed
Jul 2, 2024
| } | ||
|
|
||
| - dev_dbg(&client->dev, "dev_class: %d\n", optoe->dev_class); | ||
| + dev_dbg(&client->dev, "dev_class: %d use_smbus=%d\n", optoe->dev_class, use_smbus); |
There was a problem hiding this comment.
Is there a reason to having use_smbus be logged?
There was a problem hiding this comment.
@prgeor yes the crash is seen on platform using smbus driver so will be good to know the smbus usage in the debug log
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
saiarcot895
approved these changes
Jan 13, 2025
|
Cherry-pick PR to 202411: #456 |
mssonicbld
added
Included in 202411 Branch
and removed
Created PR to 202411 Branch
labels
|
thanks Mihir and this one is already merged with 202411 -> 202412 code sync: Azure/sonic-linux-kernel.msft@f3f9a37 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optoe driver with write-max > 1 when using the i2c message buffer was allocating only 3(1+2) bytes which means while copying the user data for i2c adapters supporting the native i2c functions will overwrite the message buffer size. This will not happen for i2c adapters that does not support native i2c functions like pure SMBUS controller.
MSFT ADO - 28209032